BBMRI-cz / fhir-module

A data integration tool for BBMRI-ERIC biobanks.
Apache License 2.0
2 stars 1 forks source link

Model and service changes #19

Closed SimonKonar closed 2 months ago

SimonKonar commented 2 months ago

Negotiator pull request:

Description:

This PR fixes multiple small issues.

  1. added storage temperature and collection datetime to Sample.
  2. add periodical upload of sample collections
  3. when checking the type of file (for validation and transformation), lowercase is applied to the name of file.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 95.03311% with 15 lines in your changes missing coverage. Please review.

Project coverage is 90.43%. Comparing base (6d9ed6a) to head (1af1d66).

:exclamation: Current head 1af1d66 differs from pull request most recent head 41c78ef

Please upload reports for the commit 41c78ef to get more accurate results.

Files Patch % Lines
util/enums_util.py 76.00% 6 Missing :warning:
persistence/sample_xml_repository.py 83.33% 3 Missing :warning:
util/config.py 57.14% 3 Missing :warning:
persistence/sample_csv_repository.py 91.66% 2 Missing :warning:
service/blaze_service.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #19 +/- ## =========================================== + Coverage 73.71% 90.43% +16.71% =========================================== Files 59 62 +3 Lines 1853 2122 +269 =========================================== + Hits 1366 1919 +553 + Misses 487 203 -284 ``` | [Flag](https://app.codecov.io/gh/BBMRI-cz/fhir-module/pull/19/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-cz) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/BBMRI-cz/fhir-module/pull/19/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-cz) | `28.51% <12.27%> (?)` | | | [unit](https://app.codecov.io/gh/BBMRI-cz/fhir-module/pull/19/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-cz) | `76.81% <94.70%> (+3.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-cz#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.