search

BBN-Q / PyQLab

A python library for instrument control and superconducting QIP experiments.
Apache License 2.0
25 stars 11 forks source link

Python 3 compatibility #122

Closed caryan closed 8 years ago

caryan commented 8 years ago

Not extensively tested but I seem to be able to go back and forth. Also note new way to get Python 3 atom/enaml stack and JSONLibrary submodule update.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.1%) to 66.803% when pulling f6055bb4d2700d516ad96c85d824defc2e4aefeb on feature/py3-compat into c87969d75e6c83a3d573961a8aa29499efae480e on develop.

grahamrow commented 8 years ago

I was able to pip install the dependencies and get it running on OSX for what it's worth: e.g. pip3 install git+https://github.com/MatthieuDartiailh/enaml.git@python3-parsing

I'm looking into embedding the quince GUI in PyQLab (or visa versa, what better to serve as the node inspector than PyQLab itself?), but looks like the mismatch in PyQt versions will prohibit this for the moment. Seems like it might happen eventually.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.1%) to 66.803% when pulling 2b1717fb70a07d815ed3e44180d17bc48d1ed49b on feature/py3-compat into c87969d75e6c83a3d573961a8aa29499efae480e on develop.

caryan commented 8 years ago

@grahamrow 46c3d97 should fix the kernel issues you were seeing

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-54.2%) to 12.457% when pulling 46c3d97611d1d632188b8bf4196ef9e053b24775 on feature/py3-compat into c87969d75e6c83a3d573961a8aa29499efae480e on develop.

blakejohnson commented 8 years ago

I'm not sure why this failed unit tests unless it was because conda didn't figure out that it needed to install pyqt. In any case, can we update the Travis script to try both python 2 and python 3 and install the dependencies as you suggest in the new README?

caryan commented 8 years ago

Yep, I'll tackle that.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 67.078% when pulling dc47ecfb49a1b18532d316d0a2009e6b73ffd0e2 on feature/py3-compat into c87969d75e6c83a3d573961a8aa29499efae480e on develop.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 67.078% when pulling c08ab16176388bcd249fb84ee2bdb95399c52432 on feature/py3-compat into c87969d75e6c83a3d573961a8aa29499efae480e on develop.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 67.078% when pulling 69ed6e1a5f1ffe6f5a789da3c820d32720f01b7d on feature/py3-compat into c87969d75e6c83a3d573961a8aa29499efae480e on develop.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 67.078% when pulling c7aedc1f02498e014232d5bbe8e99bf579ac0faf on feature/py3-compat into c87969d75e6c83a3d573961a8aa29499efae480e on develop.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 67.078% when pulling 23d3fe8add176cf12a79b135fbed0ddd0190a87f on feature/py3-compat into c87969d75e6c83a3d573961a8aa29499efae480e on develop.

caryan commented 8 years ago

@dieris you've probably given this the best real-world workout. Please merge when you're happy.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 67.101% when pulling 1603bc5c76b20708bc7b808254b8685469cb7093 on feature/py3-compat into 1d1378122e78dbfeef190a7cb56919c10709b455 on develop.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.5%) to 67.147% when pulling ab2dd50de81c53459c381e21708c6a5303e2c9f7 on feature/py3-compat into 1d1378122e78dbfeef190a7cb56919c10709b455 on develop.

matthewware commented 8 years ago

I haven't done through testing but this branch seems to be working for me on Maxwell.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.5%) to 67.147% when pulling 088ba1106e0be13ef46ca95ff3b6b51cd219eb71 on feature/py3-compat into 1d1378122e78dbfeef190a7cb56919c10709b455 on develop.

matthewware commented 8 years ago

No I thought you had merged the py3-compat into master. Seems that wasn't the case.

dieris commented 8 years ago

I'll do a final test before merging. For some reason, I didn't receive any email notifications on this branch in the last 2 days...

matthewware commented 8 years ago

I guess I'm still lost... Wasn't py3-compat on JSONLibraryUtils merged into master?