search

BBN-Q / PyQLab

A python library for instrument control and superconducting QIP experiments.
Apache License 2.0
25 stars 11 forks source link

Automate unit tests #31

Closed bcdonovan closed 9 years ago

bcdonovan commented 9 years ago

Expand upon current unit tests. Goal is to be able to apply continuous integration to PyQlab Factor out show from existing unit tests so that they may be automated

caryan commented 9 years ago

That would be pretty slick with a Travis badge.

bcdonovan commented 9 years ago

That's the goal

caryan commented 9 years ago

What I've done in other pulse sequence languages is have a h5 file with reference compiled sequences that is loaded by the test fixture to check against. Then there is an interactive/non-interactive testing mode which plots or doesn't plot the sequences.

bcdonovan commented 9 years ago

Someone with admin rights will need to enable the travis-ci.org to github connection. I do not have the rights to enable PyQLab in travis.

caryan commented 9 years ago

Done

matthewware commented 9 years ago

This looks nice Brian. Should we close this issue? Seems like Travis is working well with repo.

bcdonovan commented 9 years ago

Lets keep this open for now. I would like to add a few more unit tests as well as having travis ci working.

blakejohnson commented 9 years ago

Right, the test_QGL pieces still need to be converted to waveform masks.

bcdonovan commented 9 years ago

@blakejohnson Do you think the new test_QGL implementation is sufficient to close this or do you have more test work in mind?

blakejohnson commented 9 years ago

In terms of automation, this is sufficient. We should probably next look at code coverage (i.e. get coveralls.io up and running).

blakejohnson commented 9 years ago

This has been really great for bug fixing in the last week. Thanks, Brian.

bcdonovan commented 9 years ago

Happy to help.