search

BBN-Q / PyQLab

A python library for instrument control and superconducting QIP experiments.
Apache License 2.0
25 stars 11 forks source link

First pass at implementing simple two-qubit RB with atomic Cliffords.… #73

Closed matthewware closed 9 years ago

matthewware commented 9 years ago

We could probably shorten the name...

blakejohnson commented 9 years ago

A minor gripe, but this is simultaneous RB, not 2Q RB, no?

matthewware commented 9 years ago

That's right. I had originally written code in the pull request specifically for the two qubit case. @caryan encouraged me to make it more general.

matthewware commented 9 years ago

I'm fixed some of the obvious typos and relabeled seqs in the doc string. Is that what you were referring to Colm?

blakejohnson commented 9 years ago

It would also be good to fix the commit message.

caryan commented 9 years ago

It needs to be fixed in many of the docstrings but with the Bokeh plotting we no longer return the plot handle.

matthewware commented 9 years ago

@caryan it seems none of the basic sequences return anything. I won't convolute the commits, but is this something we should fix for all the basic sequences? Also, hat tip for the zip(*seqs) syntax!

The list compression here is not readable at all if you ask me. I'll have to see what I can do to make these more readable in the morning.