search

BBN-Q / PyQLab

A python library for instrument control and superconducting QIP experiments.
Apache License 2.0
25 stars 11 forks source link

fix for #69,#70,#71, and #72 #74

Closed rmcgurrin closed 9 years ago

rmcgurrin commented 9 years ago

69

In the Looper Form of MeasFilterViews.enaml, test that the selected filter is in the filter dictionary else return -1

70

Added a childFilter to the StateComparator class because it was missing.

71

In the QtListStrWidget, test if the enable changed when the labels are the same and the label is in the item list. Also, only signal a name change when the labels are not the same and the newlabel is not in the item list. In the old version of code there are some conditions when on_edit is called that result in the dictionary manager trying to rename an item that does not exist.

72

Added a new feature to save config in a different directory and load a config from a different directory. After loading a config, the GUI will restart itself for the changes to take effectively

blakejohnson commented 9 years ago

Rob, would you mind breaking out your fix of #70 so that we can discuss just that? The "childFilter" concept has largely been removed from the measurement filters, so I expect a different fix is needed.

rmcgurrin commented 9 years ago

I'm closing this review and resubmitting the review with the #70 change backed out. I'll tackle a root cause for that separately.

blakejohnson commented 9 years ago

There's no need to close a pull request for that kind of change. Just refactor your local branch as you want, and then force push the changes.