search

BBN-Q / PyQLab

A python library for instrument control and superconducting QIP experiments.
Apache License 2.0
25 stars 11 forks source link

RFC: bring test_data into the repo #79

Closed caryan closed 8 years ago

caryan commented 9 years ago

Currently updating the unit testing golden sequences is messy and it's a few extra hidden steps for users to get the test_data to run on any changes they make before pushing. The compressed test data is only 88kB (and only 51kB if we switch to bzip2) and I'd be okay to bring it into the repo for now.

@bcdonovan and @blakejohnson any thoughts?

matthewware commented 9 years ago

I think it sounds like a good idea for now. I'd like to be able to test locally before pushing to github and anxiously refreshing while Travis works. I might also suggest that we move the config json files or at least the paths to the test folder. Currently running the tests overwrites/clears your local config files. This makes sense for Travis, but probably not for local testing.

caryan commented 9 years ago

It looks like GitHub will give BBN-Q 1GB for git large file storage link. I've requested access for BBN-Q and it seems like the best long-term solution if the test data size ever grows. Github bundles git-lfs into the Github for Windows so it should be easy for users.

caryan commented 9 years ago

@matthewware can you file a separate issue for the config files and test_json issue.

bcdonovan commented 9 years ago

I'm comfortable bringing the test data into the repo. I like the Github LFS option but we might need to watch the bandwidth quota rather than the file size limit. I think we are currently setup for Travis will run for every push back to github. We are probably ok for now given the file size but it may start to add up.

matthewware commented 9 years ago

Looks like git-lfs is available today for all repos: https://github.com/blog/2069-git-large-file-storage-v1-0 Bandwidth is capped at 1GB per month: https://help.github.com/articles/billing-plans-for-git-large-file-storage/

matthewware commented 9 years ago

I've also been wondering if we could just create hashes for the h5 files and then check the newly created files against them?

blakejohnson commented 9 years ago

@matthewware that would be sufficient for a simple pass/fail test. But when you fail, it is nice to have some discoverability of where you are failing. That's why Brian went with storing the whole file.

caryan commented 9 years ago

There's some work a feature/git-lfs-test-files branch (5a60a111854e72706a72807d160059032aea8d20) with this at least working with git-lfs. I've spent a couple hours trying to get git-lsf to work with Travis and after some discussion with @blakejohnson I think we'll just leave it until the support from Travis is better. For future reference some notes:

caryan commented 8 years ago

An update from looking into this again. Travis have said nothing about any more updates to the 12.04 images. They have however released a 14.04 image using GCE that comes with sudo blog post that doesn't seem to have the penalties that sudo used to have.

blakejohnson commented 8 years ago

And does this new image have git lfs?

blakejohnson commented 8 years ago

It looks like it should now be possible to do install Git lfs after repo checkout and then to git lfs pull. See: https://github.com/github/git-lfs/issues/325

caryan commented 8 years ago

Sure, that's what we were doing here but the question was how do you install git lfs without sudo?

blakejohnson commented 8 years ago

Can't you install to /usr/local without sudo? I thought that was just needed to upgrade git prior to cloning.

caryan commented 8 years ago

Closed over in QGL #25