search

BBN-Q / QGL.jl

A performance orientated QGL compiler.
Apache License 2.0
12 stars 5 forks source link

WIP: Feature/AC pulses #13

Closed dieris closed 7 years ago

dieris commented 7 years ago

To be tested. Also, where should we input sampling_rate?

caryan commented 7 years ago

Since sampling_rate is just used to calculate the nutation frequency and passed through to the shape function we could defer it till then when we will be given the sampling rate by passing the Xp Pulse object

caryan commented 7 years ago

For the arb_axis_drag we also need to add the frame changes.

dieris commented 7 years ago

I'm confused, is there supposed to be a frame change at the end of the arb_axis_drag pulse? How is it accomplished here?

caryan commented 7 years ago

Seems like unnecessary copy-paste bonus that we calculate the frame change in PulseShapes.py but the point is that we have a frame change in the Pulse definition here. From QGL.jl we need to return a PulseBlock with the ZPulse.

caryan commented 7 years ago

At @dieris I'm just going to merge this so it doesn't get left dangling. We can file and fix issues when we use the pulses.