BBQuercus / deepBlink

Threshold independent detection and localization of diffraction-limited spots.

https://academic.oup.com/nar/advance-article/doi/10.1093/nar/gkab546/6312733

Other

32 stars 8 forks source link

Create QOL #128

Closed BBQuercus closed 3 years ago

BBQuercus commented 3 years ago

Proposed changes

Update two minor things in deepblink create:

Default saving location from args.inputs to pwd
Add option to control the minimum number of spots per cropped field of view using the --minspots flag.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation content update
[ ] Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code so nothing breaks.

[x] I have read the contributing guidelines
[x] Lint and unit tests pass locally with my changes (tox)
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules
[x] My commit messages format follow the project git commit message format*

💔 Thank you!

codecov[bot] commented 3 years ago

Codecov Report

Merging #128 (231054f) into master (8f39728) will increase coverage by 0.13%. The diff coverage is 4.76%.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   49.79%   49.93%   +0.13%     
==========================================
  Files          33       33              
  Lines        1452     1450       -2     
==========================================
+ Hits          723      724       +1     
+ Misses        729      726       -3

Impacted Files	Coverage Δ
deepblink/cli/_create.py	`19.11% <0.00%> (+0.41%)`	:arrow_up:
deepblink/cli/_main.py	`64.00% <ø> (ø)`
deepblink/cli/_argparse.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f39728...231054f. Read the comment docs.