I think those constructors are useless and need to be removed. Only if the constructor does actually something, like calling make() or call other New() for its embedded types, should be preserved.
Also, on constructors, there is no need to repeat the parameters with huge names:
It is confusing to see what is the struct and what is not. The point of that format is just to accommodate long parameter names which are never used outside the function.
We have a lot of constructors like:
I think those constructors are useless and need to be removed. Only if the constructor does actually something, like calling make() or call other New() for its embedded types, should be preserved.
Also, on constructors, there is no need to repeat the parameters with huge names:
Could become
Last, I would love to avoid the form:
It is confusing to see what is the struct and what is not. The point of that format is just to accommodate long parameter names which are never used outside the function.