search

BBVA / qed

The scalable, auditable and high-performance tamper-evident log project
https://qed.readthedocs.io/
Apache License 2.0
94 stars 19 forks source link

Rename Version names #139

Open iknite opened 5 years ago

iknite commented 5 years ago

Proposal:|

ActualVersion -> InsertionVersion (This is the version on the time of writing the event)
CurrentVersion -> TreeVersion (This is the version on the time of the query)
QueryVersion -> QueryVersion (This is the version asked for)

Thoughts?

gdiazlo commented 5 years ago

My proposal:

ActualVersion -> EventIndex
CurrentVerrsion -> ProofIndex
QueryVersion -> QueryIndex
iknite commented 5 years ago

Changing Version LGTM to Index, as long as we change every reference of version (and not only this 3 variables)

Using "object names" for temporality (when is stored, and consulted) seems more confusing to me, that's why I've been proposing Insertion. (and this doubt also applies to my TreeVersion proposal)

Just my 2 cents.