search

BBVA / qed

The scalable, auditable and high-performance tamper-evident log project
https://qed.readthedocs.io/
Apache License 2.0
96 stars 19 forks source link

New advanced client #82

Closed aalda closed 5 years ago

iknite commented 5 years ago

Also NewHTTPClientFromConfig seems overkill since it's only used twice

tests/riot.go
279:    client, err := client.NewHTTPClientFromConfig(cConf)

cmd/client.go
69:     client, err := client.NewHTTPClientFromConfig(clientCtx.config)
aalda commented 5 years ago

Also NewHTTPClientFromConfig seems overkill since it's only used twice

tests/riot.go
279:  client, err := client.NewHTTPClientFromConfig(cConf)

cmd/client.go
69:       client, err := client.NewHTTPClientFromConfig(clientCtx.config)

The client is also intended to be used outside QED project. I prefer to make the client's construction more flexible.