search

BBVAEngineering / ember-cli-htmlbars-minifier

Removes all whitespace in htmlbars templates
MIT License
2 stars 0 forks source link

feat(minifier): prevent stripNewLines form breaking with angle brackets #61

Closed xe21500 closed 3 years ago

xe21500 commented 3 years ago

stripNewLines is breaking some angle bracket templates when helpers are used as attribute values, i.e.:

...
@attr1={{my-helper ... }}
@attr2=
...

It removes the newline, resulting in an incorrect template:

@attr1={{my-helper ... }}@attr2=
codecov-commenter commented 3 years ago

Codecov Report

Merging #61 (9491a1c) into master (a73987f) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           21        21           
=========================================
  Hits            21        21
Impacted Files Coverage Δ
lib/htmlbars-minifier.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a73987f...9491a1c. Read the comment docs.

adrigzr commented 3 years ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: