kcmr commented 5 years ago

Ember CLI addon to bundle Web Components using ES modules:

Generates a bundle for each entry point path.
Supports sourcemaps.
Triggers a reload when the whatched files change.
Optionally generates two bundles for modern (ES modules support) and legacy browsers.
Allows to not write the script tags (intended for lazy or on demand load of the scripts).
Includes some utilities in the bundle:
- Prevents common double registration error
- ~Prevents Safari 10 downloading <script nomodule> (Browser issues)~ ¹
custom-es5-adapter is not required when transpiling Web Components using classes to ES5.

¹ Regarding polyfills:

Finally the script to prevent Safari 10 downloading nomodule scripts is not included because the addon is assuming that the hosting application supports that browser. Additionally, when autoImport is set to false, the script had to be imported from the addon folder (It doesn't sound good), so it's better to let the user include and import that script only if he needs it. Also, the file was included even if modules option was not enabled, so it was totally wrong.

The customelements-define.js script is always included in the bundle (not in vendor) because we know that it fixes a common issue when a script that registers a customElements is required by multiple files (very likely to happen). That script will be included in each of the generated bundles, but it is small enough (12 lines without minifying it) to not be an issue.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ea3d795). Click here to learn what that means. The diff coverage is 100%.

@@           Coverage Diff           @@
##             master     #1   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      4           
  Lines             ?     65           
  Branches          ?      0           
=======================================
  Hits              ?     65           
  Misses            ?      0           
  Partials          ?      0

Impacted Files	Coverage Δ
lib/config/rollup.js	`100% <100%> (ø)`
lib/config/babel.js	`100% <100%> (ø)`
lib/config/output.js	`100% <100%> (ø)`
index.js	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea3d795...838a1cd. Read the comment docs.

adrigzr commented 5 years ago

I'm not very proud of stubbing "private" methods...

Me neither. It shouldn't be done.

kcmr commented 5 years ago

I'm not very proud of stubbing "private" methods...

Me neither. It shouldn't be done.

Changed in 2f326d7 by mocking addon.app.

adrigzr commented 5 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

BBVAEngineering / ember-cli-webcomponents-bundler

Initial development #1

Codecov Report