search

BBVAEngineering / ember-modal-service

An ember-cli addon to manage modals as promises
MIT License
27 stars 12 forks source link

Glimmer components support #104

Open SergeAstapov opened 4 years ago

SergeAstapov commented 4 years ago

As Octane edition is around the corner it seem good time to get support (or at least define/discuss the plan if it's not defined yet) for Glimmer Components.

SergeAstapov commented 4 years ago

<ModalContainer /> component seem to be pretty simple to convert as not much going on in the component class.

<Modal /> might be trickier, because user defined components should extend from base component provided by the addon, however with Octane lots of things should be moved to template.

Potentially, addon may provide base component class + some component that need to be placed in each modal template.

josex2r commented 2 years ago

Sorry for the delay, more than 2 years have passed since opened.

Still working on it and should be tested in a real app before merged but it seems to work well: https://github.com/BBVAEngineering/ember-modal-service/pull/153

lougreenwood commented 1 year ago

@josex2r Is there any news on this, seems almost another year has passed 😉