BBVAEngineering / ember-modal-service

An ember-cli addon to manage modals as promises
MIT License
27 stars 12 forks source link

Feature/ember upgrade #153

Open josex2r opened 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #153 (45448aa) into master (7791d42) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         7    +1     
  Lines           82       100   +18     
=========================================
+ Hits            82       100   +18     
Impacted Files Coverage Δ
addon/components/modal-container/index.js 100.00% <100.00%> (ø)
addon/components/modal-wrapper/index.js 100.00% <100.00%> (ø)
addon/components/modal/index.js 100.00% <100.00%> (ø)
addon/helpers/open-modal.js 100.00% <100.00%> (ø)
addon/models/modal.js 100.00% <100.00%> (ø)
addon/services/modal.js 100.00% <100.00%> (ø)
addon/utils/css-transitions/has-transitions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65b4bda...45448aa. Read the comment docs.

SergeAstapov commented 2 years ago

@josex2r Thanks for working on this!

SergeAstapov commented 2 years ago

@josex2r @xe21500 @adrigzr is there something I can help to push this over the line and get released? I'm happy to help maintaining this addon.

If that could help, I can help and split changes proposed in this PR into smaller PRs that are easier to review - if that can help expedite things.

In addition to general Ember upgrades and transition to Glimmer component, this addon also great candidate for v2 format conversion

adrigzr commented 2 years ago

@etarancon, could you help @SergeAstapov with this? 😄

SergeAstapov commented 1 year ago

@josex2r @etarancon @adrigzr would you like to add me as maintainer of the addon as I can get this, general addon upgrades/maintenance and v2 format conversion done