search

BBVAEngineering / polymer-project-builder

Custom build tool for Web Components built over Polymer Build
MIT License
1 stars 2 forks source link

feat: wrap javascript bundle in an IIFE when CSP is used #41

Closed kcmr closed 4 years ago

kcmr commented 4 years ago

Wraps the generated bundled script in an IIFE to prevent having variables in window. This is not required when CSP is not used (HTML and JavaScript are not separated into different files).

codecov[bot] commented 4 years ago

Codecov Report

Merging #41 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           64        68    +4     
=========================================
+ Hits            64        68    +4
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a45391b...9a54c06. Read the comment docs.