search

BBx-Kitchen / bbj-language-server

BBj Language Server
MIT License
7 stars 6 forks source link

implement missing verbs #53

Closed StephanWald closed 2 months ago

StephanWald commented 1 year ago

some verbs simply seem to be still missing, so doing this catchall - issue, like for:

BEGIN

CLEAR 

BEGIN EXCEPT X$

ESCAPE

DROP A$

https://documentation.basis.cloud/BASISHelp/WebHelp/commands/Alphabetical_Verbs.htm

StephanWald commented 1 year ago 
enter a$,b
dhuebner commented 1 year ago

For DROP see also #52

insafuhrmann commented 1 year ago

Have a look at the missing verbs, if it is a large number it might be a good idea to pick some as examples so that the rest of the work can be done by someone else. See whether there are some good learning examples.

dhuebner commented 1 year ago

REPEAT and UNTIL is also missing

dhuebner commented 1 year ago

VKEYED

dhuebner commented 1 year ago

setopts

SebastianAdams commented 1 year ago

PRECISION 16

See: https://documentation.basis.cloud/BASISHelp/WebHelp/commands/precision_verb.htm

dhuebner commented 1 year ago

@StephanWald Verbs from the initial massage are implemented now.

dhuebner commented 1 year ago

All verbs except VKEYED are added now

StephanWald commented 1 year ago

What is so special about VKEYED? Syntax is very similar if not equal to MKEYED and XKEYED.

dhuebner commented 1 year ago

@StephanWald Nothing really special. I just saw the VKEYED was missing in some of the example projects I have and yes, MKEYED and XKEYED are almost the same. There was not enough time to implement it yesterday, I plan to work on it today.

dhuebner commented 1 year ago

@StephanWald VKEYED, MKEYED and XKEYED are added now. We need to collect the still missing verbs that should be implemented. Should we compare the existing vs. available verbs, or would you like to do it? If you can do it, then you can also prioritize them. Maybe there are also some deprecated verbs that should not be implemented?

Lotes commented 2 months ago

@dhuebner All verbs mentioned here are already part of the grammar (EDIT: And they are fully tested in the parser tests). Can we close this issue?

I started a table with one verb in each row that we could use to implement or prioritize the remaining missing verbs. I suggest to create one issue per missing verb row, so that @StephanWald can prioritize them. WDYT?

Lotes commented 2 months ago

Closed, because 'every mentioned verb' was already implemented and tested.