BC-CS481-Capstone / ReturnPalsApp

0 stars 0 forks source link

adjusted several ui composable to work with Gus' navigation #114

Closed andrew-pogue closed 8 months ago

andrew-pogue commented 8 months ago

stuff I emulated it

andrew-pogue commented 8 months ago

I like your ideas. I agree our composables should remain stateless if that's what you mean. I'll update it so that we're using view models for state like the selected pricing plan as shown in the video. I'll expose an onValueChanged parameter for the ui. I'll put Plan enum in the ViewModel.

However, the back and next buttons onclick don't have state attached to them. The exposure of these onclicks needs to end somewhere because some function needs to handle them. I don't think it's the view models responsibility to handle them. And I don't think they need to be exposed any further because their functionality is implemented via the nav controller. The view model is a mediator between the data layer and UI layer, defining onclicks is not in its scope imo.

My opinion might change here I'll try it out.