BC-SECURITY / Starkiller

Starkiller is a Frontend for PowerShell Empire.
https://www.bc-security.org/post/an-introduction-to-starkiller
MIT License
1.37k stars 196 forks source link

[BUG] Error 400 when creating new listener #5

Closed ZkClown closed 4 years ago

ZkClown commented 4 years ago

Empire Version

Starkiller Version 1.0.0. Rebuilded it from source

OS Information (Linux flavor, Python version)

Describe the bug When we attempt to create a new listener that is not an http listener, we obtain 400 error. This is due to the file: src/api/listener-api.js. We can see in the code that the function which handles the listener creation is createListener(). This function always requests the URI "/listeners/http". However when we look at Empire's code we have the API endpoint to create a listener: "@app.route('/api/listeners/', methods=['POST'])". Therefore, the URI requested in Starkiller should have been something like "listeners/$type"

To Reproduce Create a Listener that is not "http"

Expected behavior Create the good listener

Screenshots image The screenshot show the 400 error when attempting to create a listeners. The values displayed are some debug print used to find the problem.

Desktop (please complete the following information):

Additional context The workaround is to create through CLI or directly with the API to create the listener Best regards,

vinnybod commented 4 years ago

Thanks for the detailed issue! this will be in 1.0.1