BC44 / Cross-Seed-AutoDL

Scans files and finds cross-seedable torrents via Jackett
MIT License
137 stars 19 forks source link

`SearchHistory.json` is not created if missing #18

Closed hummingbirdy2 closed 3 years ago

hummingbirdy2 commented 3 years ago

I have this traceback with the --ignore-history used :

Traceback (most recent call last):
  File "/app/cross-seed/CrossSeedAutoDL.py", line 429, in <module>
    main()
  File "/app/cross-seed/CrossSeedAutoDL.py", line 357, in main
    history_json_fd = open(HistoryManager.search_history_file_path, 'r+', encoding='utf8')
FileNotFoundError: [Errno 2] No such file or directory: '/app/cross-seed/SearchHistory.json'

Is it really necessary to try to read (or check) the history file in this case ?

hummingbirdy2 commented 3 years ago

My bad I mixed up with DownloadHistory.json

BC44 commented 3 years ago

Yes, it needs to write new downloads to it. I've fixed it in 5aad05938ef22eda985d0a0e85102b9ccb0082f1

Btw DownloadHistory.json is old and no longer used. It's a relic of an older version of the script

hummingbirdy2 commented 3 years ago

Thanks for the hot fix.

I don't understand the option --ignore-history if it steal need to write the new dl.

Seems not available for the moment. Is it possible to have the possibility to chose the path of the SearchHistory.json by a option ? To have an easiest gestion of the history with docker.

BC44 commented 3 years ago

--ignore-history is there to allow torrents to be searched and downloaded even if they've already been searched/downloaded. It will still need to log the results for future iterations

hummingbirdy2 commented 3 years ago

Thanks for the clarification