BC46 / freelancer-hd-edition

Freelancer: HD Edition is a mod that aims to improve every aspect of the game Freelancer (2003) while keeping the look and feel as close to vanilla as possible.
https://www.moddb.com/mods/freelancer-hd-edition
168 stars 15 forks source link

Briesen Mining Facility crash on server after undocking #108

Closed BC46 closed 2 years ago

BC46 commented 2 years ago

A vanilla player has reported an issue regarding a crash which occurred after undocking from Briesen Mining Facility (BW03) on a JFLP server. Since this is a JFLP issue, it's an HDE issue too.

I had a quick go at trying to reproduce the issue. I was running a vanilla client on the same JFLP server, but I couldn't get it to crash, not even after 5 undocks. I've been provided a save file of the user in question which will hopefully give me better luck.

Drakohen commented 2 years ago

This issue was discussed in Discord back in Jan 2022 with Bolte being the one to encounter it:

Briesen Mining Facility - Crash when [entering] combat [with] Hessians within [a] few seconds

He wasn't able to replicate the issue again and when I attempted to produce the same issue, I was never successful.

Here is some additional info we will need: Is the client running on a known public server or their own? What version of JFLP is the server running? Is the client truly "vanilla"? Crash logs would be very helpful to see what offset, if any, is being triggered.

As for my personal opinion, this is definitely not an encounter/patrol path issue since all those are produced server side and then passed to the client. If there was an issue, the server would of crashed. I think the issue might be similar to the problem caused by JFLP 1.25 in regards to changing base nicknames in the system ini which would cause a mismatch between a vanilla client and JFLP server, i.e. Ronnenburg and Yanagi. Some file compares and additional testing seem to be in order.

Drakohen commented 2 years ago

Well after looking through all my Discord servers I frequent, I see this was on the ZU server so that answers a few of my first questions. I wonder if this person has a corrupted install since I have heard rumors of some bad FL distributions. Additionally, I wonder if the client installed the JFLP version that the server uses, the problem would go away? Again, crash logs could potentially be useful the next time this occurs.

BC46 commented 2 years ago

I just tested the provided save file using a 100% vanilla client on a JFLP server. Performed 7 undocks from Briesen and I didn't experience a single crash. I also tried installing the official 1.1 patch but to no avail. I even jumped on the server where the crash took place (Zoner Universe) using the same client; no crashes there either.

One more thing I tried was to make both the Hessian and Daumann fighters hostile whilst I was flying near the base. No unexpected results or anything.

BC46 commented 2 years ago

I'm afraid we have to put this one in the "Can't reproduce" basket for now. Feel free to reopen once new insights have been found into how it can be reproduced.