search

BC46 / freelancer-hd-edition

Freelancer: HD Edition is a mod that aims to improve every aspect of the game Freelancer (2003) while keeping the look and feel as close to vanilla as possible.
https://www.moddb.com/mods/freelancer-hd-edition
161 stars 14 forks source link

Investigate whether performance issues occur with the effect_types.ini changes #177

Closed BC46 closed 2 months ago

BC46 commented 1 year ago

A while ago I updated the effect_types.ini file to ensure that every effect exists off-screen and gets updated off-screen (https://github.com/BC46/freelancer-hd-edition/commit/5962afdd80635088c684cbee45835a3c992c7ff4). However, since doing this I always had this idea in the back of my head that it may somehow cause performance issues. I never did any proper tests because at first I thought everything will be fine, but now I would like to have this figured out. Because it's possible that these changes may cause unnecessary stutters/lag during large battles for example.

erikroe commented 11 months ago

Generally effects and particle systems are one of the most expensive things a game has, next to shadow calculations (which FL does not have). So it makes perfect sense to even in FL try and have a good performance on effects. Especially since you also have set up system-wide effect visibilities with the high pbubble values.

BC46 commented 11 months ago

Despite the very high values for pbubble, no effect will be drawn beyond the space_farclip (poly flipping) distance, which is set to 40,000 in HDE.

BC46 commented 2 months ago

I'm going to revert the changes made in effect_types.ini because they do not really make a significant difference anyway (appearance-wise).