BCA-Team / Buildcraft-Additions

Extending Buildcraft with Fluid Canisters, Kinetic Capsules, Power Tools and much more!
http://aenterprise.info/BCA-docs
GNU General Public License v3.0
26 stars 14 forks source link

Crash when removing Large KEB block #463

Open DoesItDoIt opened 8 years ago

DoesItDoIt commented 8 years ago

Removing one block from Large KEB makes server crash and world unplayable after that - had to restore from backup. Made a test and it seems to happen only if there is RF going through KEB, but I'm not sure. crash-2016-03-13_03.15.58-server.txt

AEnterprise commented 8 years ago

seems the problem is in eureka, did you remove the block manually or automated?

iTitus commented 8 years ago

I would suggest adding Nullchecks everywhere in the Eureka code :P

iTitus commented 8 years ago

BTW, you are using Optifine and your Player name is "Player". Are you in offline mode or did you not buy the game?

DoesItDoIt commented 8 years ago

Block was removed manually with Kinetic Multi-tool from the same mod if it matters. Also after a couple of tests I noticed it crushed all the time I removed a block from a lower row of KEB, although it could be a coincidence as well. Eureka integration was disabled, because I do like this mod (really, really awesome job here - combination of BC and BCA is what a good tech mod should be), but this learn-as-you-go system just doesn't fit the idea in my opinion.

DoesItDoIt commented 8 years ago

As of the latter question - I use optifine and fastcraft as my laptop is not particularly good for gaming and I get around 5-15 fps around all the BC and BCA machinery without them, but steady 30-50 with both enabled. About the "player" - you're utterly right about the reasons (both of your assumptions are true), but I don't use any custom launchers or modloaders but forge 10.13.4.1614 and MC original launcher.

AEnterprise commented 8 years ago

i suspect the offline mode is causing the player to be null, i didn't think that was possible

iTitus commented 8 years ago

I think getExtendedProperties returns null and so the cast does not work. The null player is catched by the if-statement.

Am 13.03.2016 um 15:53 schrieb AEnterprise notifications@github.com:

i suspect the offline mode is causing the player to be null, i didn't think that was possible

— Reply to this email directly or view it on GitHub.