search

BCCHR-IT / custom-template-engine

REDCap module that allows you to create HTML templates and fill them with record data from your project. You can download the filled templates as a PDF, which are saved to the File Repository.
MIT License
10 stars 7 forks source link

Compatible with PHP 8.0+ ? #33

Closed 274188A closed 1 year ago

274188A commented 2 years ago

click on the menu item for the EM image

...and I see this error: image

If I revert PHP to 7.4*, then it works OK - assuming this was written in such a way to not be compatible with v 8 of PHP

Is anybody maintaining this EM? Be good to get it going for PHP 8...

BCCHR-IT commented 2 years ago

Hello,

This Dan Evans, the development team lead at BCCHR.

The Custom Template Engine was developed and tested under PHP7. We have not yet started migration to PHP8, so we have not yet extended support for this software beyond PHP7. In the New Year, if you are able to assist us with your 8.x installation, we can test a fix to the CTE that would be backward compatible with 7. Otherwise we'll need to wait until we begin our process of moving to newer software for our REDCap host, which is not yet slated.

If you are able to assist us come January, please reach out directly to me; we'd love your help!

Best,

Dan

?

Dan Evans Team Lead, Programming - Research IT BC Children's Hospital Research Institute, a program of the Provincial Health Services Authority A1-110 950 West 28th Avenue, Vancouver, BC V5Z 4H4 T: 604-875-2000 x4888 | M: 604-785-0350 | E: @.***

From: Foo @.***> Sent: Thursday, December 16, 2021 10:13 PM To: BCCHR-IT/custom-template-engine Cc: Subscribed Subject: [BCCHR-IT/custom-template-engine] Compatible with PHP 8.0+ ? (Issue #33)

click on the menu item for the EM [image]https://user-images.githubusercontent.com/40014477/146497726-95be4d8a-8f90-4e1f-803d-8292c0b67e88.png

...and I see this error: [image]https://user-images.githubusercontent.com/40014477/146497525-87a47206-c0e5-4b0b-94c9-2d9fce8dd8ba.png

If I revert PHP to 7.4*, then it works OK - assuming this was written in such a way to not be compatible with v 8 of PHP

Is anybody maintaining this EM? Be good to get it going for PHP 8...

- Reply to this email directly, view it on GitHubhttps://github.com/BCCHR-IT/custom-template-engine/issues/33, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALZA3Q4ETADAMLCB4BE37M3URLIKDANCNFSM5KIBZSVQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.***>

274188A commented 2 years ago

Hi Dan, sure happy to help. I have a test server (not public facing) that I can use to test your code.

Cheers, John

John Barrett Developer & REDCap Administrator School of Population Health

Curtin University Tel | +61 8 9266 1854

@.***

CRICOS Provider Code 00301J

From: BCCHR - REDCap @.> Sent: Saturday, 18 December 2021 5:37 AM To: BCCHR-IT/custom-template-engine @.> Cc: John Barrett @.>; Author @.> Subject: Re: [BCCHR-IT/custom-template-engine] Compatible with PHP 8.0+ ? (Issue #33)

Hello,

This Dan Evans, the development team lead at BCCHR.

The Custom Template Engine was developed and tested under PHP7. We have not yet started migration to PHP8, so we have not yet extended support for this software beyond PHP7. In the New Year, if you are able to assist us with your 8.x installation, we can test a fix to the CTE that would be backward compatible with 7. Otherwise we'll need to wait until we begin our process of moving to newer software for our REDCap host, which is not yet slated.

If you are able to assist us come January, please reach out directly to me; we'd love your help!

Best,

Dan

?

Dan Evans Team Lead, Programming - Research IT BC Children's Hospital Research Institute, a program of the Provincial Health Services Authority A1-110 950 West 28th Avenue, Vancouver, BC V5Z 4H4 T: 604-875-2000 x4888 | M: 604-785-0350 | E: @.<mailto:@.>

From: Foo @.<mailto:@.>> Sent: Thursday, December 16, 2021 10:13 PM To: BCCHR-IT/custom-template-engine Cc: Subscribed Subject: [BCCHR-IT/custom-template-engine] Compatible with PHP 8.0+ ? (Issue #33)

click on the menu item for the EM [image]https://user-images.githubusercontent.com/40014477/146497726-95be4d8a-8f90-4e1f-803d-8292c0b67e88.png

...and I see this error: [image]https://user-images.githubusercontent.com/40014477/146497525-87a47206-c0e5-4b0b-94c9-2d9fce8dd8ba.png

If I revert PHP to 7.4*, then it works OK - assuming this was written in such a way to not be compatible with v 8 of PHP

Is anybody maintaining this EM? Be good to get it going for PHP 8...

- Reply to this email directly, view it on GitHubhttps://github.com/BCCHR-IT/custom-template-engine/issues/33, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALZA3Q4ETADAMLCB4BE37M3URLIKDANCNFSM5KIBZSVQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.<mailto:@.>>

— Reply to this email directly, view it on GitHubhttps://github.com/BCCHR-IT/custom-template-engine/issues/33#issuecomment-997045312, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJRJFDPIDKML5MXBZYWFRATUROUOBANCNFSM5KIBZSVQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.**@.>>

274188A commented 2 years ago

Still waiting to help...

lsgs commented 2 years ago

Hello Dan, John,

The PR I just submitted has a couple of fixes in it that makes it work in my PHP8 dev environment. It also contains some additional functionality that I believe will be useful to many (e.g. John - you will generally use A4 rather than Letter paper, I expect).

The new features are essential for us so I am running a forked version of the module for now. It will be great if you can take a look, Dan, and consider merging them. https://github.com/BCCHR-IT/custom-template-engine/pull/36

274188A commented 2 years ago

Hi @lsgs, I got a little impatient and did a manual install of your fork. The EM seems to work very well.

BCCHR-IT commented 1 year ago

Hello,

Just merged changes to make this compatible with PHP 8. We are also planning a release soon of a new version of CTE that will be compatible with the instrument-level data export rights introduced in REDCap v13. We are not currently planning on making it backward compatible with the deprecated permission scheme, so the new release will not be backward compatible with this code.

BCCHR-IT commented 1 year ago

Closing this issue.