BCCN-Prog / weather_2016

For the BCCN 2016 advanced programming project
3 stars 1 forks source link

owm sometimes does logically impossible predictions: what do we do with them? #57

Closed clauslang closed 8 years ago

clauslang commented 8 years ago

Sometimes, for the daily predictions, owm says that the highest temperature is lower than the lowest one, e.g.:

file: owm_06_06_2016_05_18_frankfurt.html prediction for: June 15th high: 19.2°C low: 19.7°C (see attached screenshot and file)

For now, we ignore the prediction of that day completely (because Jan's test of the output raises an AssertinError). But I think, we should actually add the values to the DB. First, because we shouldn't manipulate the data that we get from the websites. Second, this is an interesting result if we are analyzing e.g. the prediction accuracy of the different sites.

owm_06_06_2016_05_18_frankfurt.html.zip

2016-06-21 05 25 01 pm

daveh19 commented 8 years ago

I agree. Save it to the database.

clauslang commented 8 years ago

Need to adjust the output tester accordingly then, @janfb

janfb commented 8 years ago

I could either just remove this test from testing or make an exception for owm.