search

BCDA-APS / adl2pydm

Convert MEDM's .adl files to PyDM's .ui format
Other
0 stars 4 forks source link

REF: fall back to QLabel if no channel is associated with PyDMLabel #55

Closed klauer closed 4 years ago

klauer commented 4 years ago

This doesn't have to be accepted here, but it's one possible solution for a downstream typhos issue that may be agreeable.

In downstream Typhos, we have specific stylesheets for PyDMLabel, making the auto-converted AreaDetector screens look particularly bad:

image

With this fix, the channel-less PyDMLabel is recast to a QLabel:

image

Separately - would you mind a PR that fixes trailing whitespace issues in the repository? My editor found and fixed hundreds automatically, making contributing a bit more difficult.

prjemian commented 4 years ago

I like this.

klauer commented 4 years ago

It's not bad to read through at all! :+1:

klauer commented 4 years ago

Do you want anything else from my PRs in this repo @prjemian?