BCDA-APS / bluesky_training

Bluesky training, including instrument package
https://bcda-aps.github.io/bluesky_training/
Other
11 stars 0 forks source link

bluesky-queueserver v0.0.18 changes changes group admin to primary #134

Closed prjemian closed 1 year ago

prjemian commented 1 year ago

A change was made to main in commit 20a9e3f but there are other files to be changed as well. Deserves its own branch and PR.

prjemian commented 1 year ago

After changes to main were reversed, CI for Py 3.8 failed (tests all passed) with:

coveralls.exception.CoverallsException: Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs

which seems to be a new problem.

prjemian commented 1 year ago

Perhaps this suggestion:

run: coveralls --service=github

https://github.com/BCDA-APS/bluesky_training/blob/52f4b2dec35fa61031b2309cfe4ea31a53d3de0b/.github/workflows/unit-tests-pytest.yml#L159-L160

The change exists on line 160. Guessing it needs to be added on line 159. Start the branch with that change first.

prjemian commented 1 year ago

per the help:

Usage:
    coveralls [options]
    coveralls debug [options]

    Debug mode doesn't send anything, just outputs json to stdout. It also
    forces verbose output. Please use debug mode when submitting bug reports.

Global options:
    --service=<name>  Provide an alternative service name to submit.
    --rcfile=<file>   Specify configuration file. [default: .coveragerc]
    --output=<file>   Write report to file. Doesn't send anything.
    --merge=<file>    Merge report from file when submitting.
    -h --help         Display this help.
    -v --verbose      Print extra info, always enabled when debugging.
prjemian commented 1 year ago

Reading further, remove line 159 altogether.

prjemian commented 1 year ago

Define COVERALLS_REPO_TOKEN per https://github.com/lemurheavy/coveralls-public/issues/1435#issuecomment-742961333

prjemian commented 1 year ago

Different advice from lemurheavy (above):

prjemian commented 1 year ago

CI passes now. Proceed with #134 now