search

BCDA-APS / bluesky_training

Bluesky training, including instrument package
https://bcda-aps.github.io/bluesky_training/
Other
11 stars 0 forks source link

Installation guide review #143

Closed rodolakis closed 1 year ago

rodolakis commented 1 year ago
rodolakis commented 1 year ago

Fixed _create_conda_env. I was planning to do that later (in a separated conda dedicated branch), but it think is is in a decent shape as is for now.

prjemian commented 1 year ago

In my local docs build, ran into this:

/path/to//bluesky_training/docs/source/instrument/index.rst:21: WARNING: toctree contains reference to nonexisting document 'instrument/instrument_template'
/path/to/bluesky_training/docs/source/reference/_FAQ.rst:7: WARNING: Duplicate explicit target name: "here".
prjemian commented 1 year ago

I'll fix those two files from my end.

prjemian commented 1 year ago

I missed that the FAQ is a .rst document with my https://github.com/BCDA-APS/bluesky_training/pull/143#pullrequestreview-1415074540 above. My suggestion does not work. Reverting those back to the original format.

prjemian commented 1 year ago

Just came across a lot of references to http://nsls-ii.github.io which are really, really old. In most (?all?) cases, those should be changed to the appropriate https://blueskyproject.io site. Needs some though.

I can take this on.

prjemian commented 1 year ago

Also will look for any changes from http:// to https://