search

BCDA-APS / bluesky_training

Bluesky training, including instrument package
https://bcda-aps.github.io/bluesky_training/
Other
11 stars 0 forks source link

taxi/fly example with busy records #248

Closed prjemian closed 6 months ago

prjemian commented 11 months ago
prjemian commented 11 months ago

Might be more useful if added a second example using sscan record and collecting data.

prjemian commented 11 months ago

Also, this is more an example than a HOWTO. Moving...

prjemian commented 9 months ago

unit test failure:

Run CMD="import ophyd"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/ophyd/__init__.py", line 92, in <module>
    from .areadetector import *  # noqa: F401, F402, E402, F403
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/ophyd/areadetector/__init__.py", line 7, in <module>
    from .base import *  # noqa: F401, F402, E402, F403
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/ophyd/areadetector/base.py", line [22](https://github.com/BCDA-APS/bluesky_training/actions/runs/6619635192/job/17980549611?pr=248#step:12:23), in <module>
    import networkx as nx
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/networkx/__init__.py", line 35, in <module>
    from networkx import generators
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/networkx/generators/__init__.py", line 5, in <module>
    from networkx.generators.atlas import *
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/networkx/generators/atlas.py", line 54, in <module>
    ATLAS_FILE = importlib.resources.files("networkx.generators") / "atlas.dat.gz"
AttributeError: module 'importlib.resources' has no attribute 'files'
Error: Process completed with exit code 1.
prjemian commented 9 months ago

Web search suggests an answer: jsonschema >= 4 breaks conda

Review these reports that resolved this problem elsewhere.

prjemian commented 9 months ago

In this case, these versions:

2023-10-23T22:15:53.1899155Z   jsonschema                     4.19.1        pyhd8ed1ab_0            conda-forge
2023-10-23T22:15:53.1900357Z   jsonschema-specifications      2023.7.1      pyhd8ed1ab_0            conda-forge
2023-10-23T22:15:53.1901614Z   jsonschema-with-format-nongpl  4.19.1        pyhd8ed1ab_0            conda-forge
2023-10-23T22:15:53.2213870Z   python-fastjsonschema          2.18.1        pyhd8ed1ab_0            conda-forge
prjemian commented 9 months ago

Note the previous unit test failure did not recur. Assume it was a transient problem.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 8543743070

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Files with Coverage Reduction New Missed Lines %
bluesky/instrument/devices/temperature_signal.py 1 93.22%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 8054742528: -0.07%
Covered Lines: 983
Relevant Lines: 1189
💛 - Coveralls
prjemian commented 6 months ago

@MDecarabas @rodolakis - Finally, this is ready for review.

@cpchuang -- Preview the document at this URL: https://github.com/BCDA-APS/bluesky_training/blob/247-howto-busy-taxi-fly/docs/source/example/_busy_fly_scan.ipynb

prjemian commented 6 months ago

Seems more natural to override the busy.trigger() method instead of making a new busy.set(v) method where the v argument is ignored.

prjemian commented 6 months ago

This CI error seems transient. Ignoring for now.