search

BCDA-APS / bluesky_training

Bluesky training, including instrument package
https://bcda-aps.github.io/bluesky_training/
Other
11 stars 0 forks source link

device_read2table --> listdevice #299

Closed prjemian closed 2 months ago

prjemian commented 2 months ago
coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 8869693141

Details

Files with Coverage Reduction New Missed Lines %
bluesky/instrument/devices/temperature_signal.py 1 93.22%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 8607748681: -0.08%
Covered Lines: 983
Relevant Lines: 1189
💛 - Coveralls
prjemian commented 2 months ago

To re-generate the notebooks, https://github.com/BCDA-APS/apstools/issues/972 is needed to interact with the aps object again. This PR (which so far only changes the name of the function called) could be merged but the output will not match. It could be weeks until the PVs become available again.

I suggest merging now, with an additional issue to re-run the notebooks once the aps device is updated.

prjemian commented 2 months ago

@MDecarabas Thanks!