BCDA-APS / bluesky_training

Bluesky training, including instrument package
https://bcda-aps.github.io/bluesky_training/
Other
11 stars 0 forks source link

changes for notebooks #30

Closed prjemian closed 3 years ago

prjemian commented 3 years ago

@mdwyman: Thanks for these review comments:

Notebooks -- worked through hello_world, basic-motor-scaler-scan, custom_plan, and databroker_analysis. However, I didn't do all of the "Challenges"/"Next Steps", but I did look through them. a. From basic-motor-scaler-scan, I had to set the names of scaler channels using the caQtDM screen, but the iocgp caqtdm script bad link (6-1 instead of 6-2). I've attached a pic b. Also from basic-motor-scaler-scan: For the challenges -- is the plan to give attendees time to work them individually, work on them collaboratively or will it be instructor-led/prompted? c. Also in challenges: maybe put a link to logger info for 4th challenge (you do have documentation references in custom_plan.ipynb) d. In custom_plan.ipynb, in 3rd cell ("scaler1.select_channels(["I0","diode"])"), had to go back to caQtDM to add names I0 and diode for two of the scaler channels (don't know if this was intended) e. In custom_plan.ipynb, same question about 'Next Steps' as for challenges in previous notebook? Individual, collaborative, or instructor-led/prompted?

prjemian commented 3 years ago

Time expectations are described in the course overview. They will be refined following the first session of this class. Roughly