BCDA-APS / bluesky_training

Bluesky training, including instrument package
https://bcda-aps.github.io/bluesky_training/
Other
11 stars 0 forks source link

add 2D slits to training instrument #90

Closed prjemian closed 1 year ago

prjemian commented 1 year ago
prjemian commented 1 year ago

@cpchuang, @pken: This file adds the slits as slit1

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4621253854


Totals Coverage Status
Change from base Build 4545648410: 0.2%
Covered Lines: 832
Relevant Lines: 1039

💛 - Coveralls
prjemian commented 1 year ago

@rodolakis Thanks for the review. I made the changes you requested, then adjusted the documentation a bit more. Can you review again?

prjemian commented 1 year ago

Here is a full view of the most-recent edit: https://github.com/BCDA-APS/bluesky_training/blob/89-2d_slits/bluesky/instrument/devices/slits.py

prjemian commented 1 year ago

@rodolakis Thanks!