BCDA-APS / gemviz

Data visualization for tiled
https://bcda-aps.github.io/gemviz/
Other
4 stars 0 forks source link

Refactor as MVC #128

Closed prjemian closed 1 year ago

prjemian commented 1 year ago

These changes should make it clearer where to add support for other catalogs. When a CatalogOfBlueskyRuns is selected, appropriate controls are presented that simplify browsing that catalog.

ATM, other types of catalogs are not supported, so an empty widget is presented with a note.

prjemian commented 1 year ago

@rodolakis Ready for review!

prjemian commented 1 year ago

image

rodolakis commented 1 year ago

can you give me a bit of time time to review this? I am all caught up except for PR #73 and #112. I kept them for the end since they were somewhat independent (and you kept adding to my plate with the rest of the code lol).

prjemian commented 1 year ago

Found a bug, so moving back to draft status. When opening the About ... dialog, the app crashed with this exception:

(bluesky_2023_2) jemian@otz ~/.../BCDA-APS/gemviz $ Traceback (most recent call                                                 last):
  File "/home/beams1/JEMIAN/Documents/projects/BCDA-APS/gemviz/gemviz/mainwindow.py", line 47, in doAboutDialog
    about = AboutDialog(self)
  File "/home/beams1/JEMIAN/Documents/projects/BCDA-APS/gemviz/gemviz/aboutdialog.py", line 21, in __init__
    self.setup()
  File "/home/beams1/JEMIAN/Documents/projects/BCDA-APS/gemviz/gemviz/aboutdialog.py", line 35, in setup
    self.mainwindow.status = f"About {__init__.APP_TITLE}, {pid=}"
AttributeError: can't set attribute 'status'
rodolakis commented 1 year ago

I just tried to run the app.py and got the following error after opening the tiled server:

Traceback (most recent call last):
  File "/home/beams3/RODOLAKIS/src/tiled-viz2023/gemviz/mainwindow.py", line 125, in catalogSelected
    self.mvc_catalog = BRC_MVC(self)
  File "/home/beams3/RODOLAKIS/src/tiled-viz2023/gemviz/bluesky_runs_catalog.py", line 32, in __init__
    self.setup()
  File "/home/beams3/RODOLAKIS/src/tiled-viz2023/gemviz/bluesky_runs_catalog.py", line 36, in setup
    from gemviz.bluesky_runs_catalog_run_viz import BRCRunVisualization
ModuleNotFoundError: No module named 'gemviz'
Aborted (core dumped)
prjemian commented 1 year ago

Start from the root directory and use this command: python ./gemviz/app.py &

prjemian commented 1 year ago

This will be fixed by #98

prjemian commented 1 year ago

@rodolakis Have we addressed all the review questions? I resolved some conversations but left others open for you to decide.

rodolakis commented 1 year ago

all good