Closed rodolakis closed 1 year ago
I agree that once tiled is updated (#53), this code should be adjusted per the TODO comment.
Add that issue number to the comment on line 81.
This fails silently. It could report the exception to the statusbar. That would coach the user about why this query failed.
The problem I encountered several times yesterday is that the status bar tends to be overwritten but other messages. I don't have specific examples though, I will try to document this.
I added the reference to both this PR and issue #53. I also added an update to the status bar: https://github.com/BCDA-APS/gemviz/blob/47c27e232e9dffc4de2056ebee33d71ada052064/gemviz/bluesky_runs_catalog_search.py#L80
However like I said earlier, the status bar is overwritten by the displayTable call. We need to somehow pass that information to the slot?
This fails silently. It could report the exception to the statusbar. That would coach the user about why this query failed.
The problem I encountered several times yesterday is that the status bar tends to be overwritten but other messages. I don't have specific examples though, I will try to document this.
A history (or logging) window might be an addition. In a new issue.
The behavior that would make the most sense to me if some text is entered would be to return an empty catalog (anything else triggers a lot of error since a catalog is expected to be returned). That would clear the tableview, clearly showing that the user did something wrong. I found this:
but I think our version of tiled is too old: