BCDA-APS / gemviz

Data visualization for tiled
https://bcda-aps.github.io/gemviz/
Other
4 stars 0 forks source link

make about box truly modal #26

Closed prjemian closed 1 year ago

prjemian commented 1 year ago

The about box is not yet modal (it allows interaction with other parts of the application before the dialog is dismissed).

prjemian commented 1 year ago

Let's work on this together. It will be a good example of the issue-branch-PR-review-merge process.

prjemian commented 1 year ago

This code: https://github.com/BCDA-APS/tiled-viz2023/blob/88f8e4c27de55ef44760a46f25709d1b4ed87d48/gemviz23/demo/mainwindow.py#L42

should be changed to:

 about.exec_()
prjemian commented 1 year ago

Two modes of dialog box:

style PyQt code effect
modal widget.exec() (same as widget.exec_()) dialog must be closed before any other parts of the UI can be used
modeless widget.show() can use other parts of the UI while dialog is open