search

BCDA-APS / gemviz

Data visualization for tiled
https://bcda-aps.github.io/gemviz/
Other
4 stars 0 forks source link

most recent run does not appear when the catalog is first opened. #96

Closed prjemian closed 1 year ago

prjemian commented 1 year ago

Still, there is a problem that the most recent run does not appear when the catalog is first opened.

Originally posted by @prjemian in https://github.com/BCDA-APS/gemviz/issues/95#issuecomment-1661171731

When opening a catalog (with knowledge that there are new runs in the catalog), the new runs do not appear when paging to the latest page of runs. Not quite sure what is going on here. (might be related to #57) Observe that when low end of slider (or low date) is set close the high date, the latest run(s) appear.

prjemian commented 1 year ago

Looks related to #51 but might depend on the tiled server. Needs diagnosis.

prjemian commented 1 year ago

On second look, #51 is related to the tiled server and how it handles delivery of many search results.

prjemian commented 1 year ago

As is typical, the problem is in a different place, pertaining to an underlying assumption. These two lines trigger the problem:

https://github.com/BCDA-APS/gemviz/blob/297f8cbb7142724567d38ea2894ef9760f31b7d3/gemviz23/demo/filterpanel.py#L87-L88

Ultimately, the until value is handled, when searching the catalog for runs, by this comparison:

https://github.com/BCDA-APS/gemviz/blob/297f8cbb7142724567d38ea2894ef9760f31b7d3/gemviz23/demo/utils.py#L52

The assumption is to use Python's comparison notion that a value will be found within a range: low <= value < high. The assumption of less than but not equal to the high limit will always fail when we search for a run with start that is exactly high.

prjemian commented 1 year ago

Actually allows until <= high, that is.