4 folder model - Githubissues

BCDA-APS / mdaviz

Data visualization for mda

https://bcda-aps.github.io/mdaviz/

Other

3 stars 0 forks source link

4 folder model #21

Closed rodolakis closed 1 year ago

rodolakis commented 1 year ago

close #4
close #12
close #13
close #18
close #19
close #23
close #15
close #9

rodolakis commented 1 year ago

Ready for review. This is a big one, sorry....

rodolakis commented 1 year ago

The subfolder slot turned out to be a lot more complicated than I expected, I am going to be yelled at...

rodolakis commented 1 year ago

switching back to draft, I am not satisfied with my refresh behavior.

rodolakis commented 1 year ago

Finally ready for review

prjemian commented 1 year ago

mainwindow.py, Line 32: The name checkMdaFiles implies an action. This value describes a finding rather than an action, consider rename to hasMdaFiles.

(For some reason, GH is not accepting my comment for this line.)