search

BCDA-APS / mdaviz

Data visualization for mda
https://bcda-aps.github.io/mdaviz/
Other
3 stars 0 forks source link

Refactor SelectFieldsTableView? #92

Open rodolakis opened 7 months ago

rodolakis commented 7 months ago

@prjemian:

I believe you are the one who came up with the logic for the checkboxes in SelectFieldsTableView: the self.selections attribute is not encapsulated. Do you remember why? I keep staring at it and can't really tell if it matters or not. It just bothers me a bit, for consistency-sake.

prjemian commented 7 months ago

Looks like an oversight to me. We should make it consistent. Gemviz has this same situation.