search

BCDA-APS / mdaviz

Data visualization for mda
https://bcda-aps.github.io/mdaviz/
Other
3 stars 0 forks source link

Refactor code to be consistent with Qt's get/set pattern. #95

Open rodolakis opened 4 months ago

rodolakis commented 4 months ago

I use the logic of internal attribute / external method, have the get methods implemented, but skipped the set method rule.

prjemian commented 4 months ago

https://en.m.wikipedia.org/wiki/Encapsulation_(computer_programming)

On Wed, Feb 28, 2024, 5:20 PM Fanny Rodolakis @.***> wrote:

I use the logic of internal attribute / external method, but skipped the set method rule.

— Reply to this email directly, view it on GitHub https://github.com/BCDA-APS/mdaviz/issues/95, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARMUMFEVXCMSCWPLC6UHZLYV63U7AVCNFSM6AAAAABD65OI5OVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE3DAMBUGQ2DGNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

rodolakis commented 4 months ago

In mda_folder.py: 

def updateSelectionField(self, new_selection):
        self._selection_field = new_selection

is effectively playing the role of what should be self.setSelectionField()