search

BCDevOps / backup-container

A simple container for a simple backup strategy.
Apache License 2.0
42 stars 56 forks source link

Update CronJob to use the `batch/v1` API. #105

Closed WadeBarnes closed 1 year ago

WadeBarnes commented 1 year ago

Resolves #104

WadeBarnes commented 1 year ago

@jujaga, Do you have an environment you could use to test this change? The change should work. I see BCDevOps/certbot is using the batch/v1 API and it works fine.

jujaga commented 1 year ago

@jujaga, Do you have an environment you could use to test this change? The change should work. I see BCDevOps/certbot is using the batch/v1 API and it works fine.

I just checked one of our environments using the backup-container and it looks like the definition is already on apiVersion batch/v1. It's possible that the OC cli or OCP auto-translated the definition by itself. As far as I'm aware, there aren't any notable structural changes between batch/v1beta1 and batch/v1, at least none that should in theory affect this. That being said, we're still on version 2.4.0 so we're behind a few versions and haven't had a chance to evaluate the latest changes yet.

pbolduc commented 1 year ago

It's possible that the OC cli or OCP auto-translated the definition by itself.

I am not aware this is a feature of OpenShift. According to Preparing to upgrade to OpenShift Container Platform 4.9, "Administrators must migrate the affected components to use the appropriate new API version.". It would be interesting to find out from the Platform Services team if they perform this migration. I would expect they would not touch project's manifests.

Beyond that, this PR LGTM.