BCDevOps / backup-container

A simple container for a simple backup strategy.
Apache License 2.0
42 stars 56 forks source link

Update TZ comment reference in backup.conf #36

Closed mark-walle closed 4 years ago

mark-walle commented 4 years ago

Correcting comment since system TZ has been changed to PST local.

thorwolpert commented 4 years ago

Why? Gov't std is UTC for all databases. Postgres stores in UTC by default internally. I don't think it's an error to be in UTC and we'd change it back from PST to UTC for ourselves.

mark-walle commented 4 years ago

@thorwolpert I agree with what you're saying. But the point of this commit was merely to fix a documentation error left over from this commit https://github.com/BCDevOps/backup-container/commit/f2ecda49ffcd2155d3cb1d40233b055f6bbed738. It's that commit where the dockerfile has been changed to ENV TZ=PST8PDT.

WadeBarnes commented 4 years ago

@thorwolpert, This has to do with cron job backup schedules, not the TZ used for a live copy of a database.