search

BCDevOps / backup-container

A simple container for a simple backup strategy.
Apache License 2.0
42 stars 56 forks source link

MariaDB support #64

Closed Sybrand closed 3 years ago

Sybrand commented 3 years ago

Added MariaDB support

This plugin should also work with rhl mysql image, but is untested.

esune commented 3 years ago

I will take a look and test asap, and report back. We have a MariaDB database, I will setup a test instance to conduct tests safely.

esune commented 3 years ago

Tested by creating a backup and restoring it on MariaDB: everything works great. I would expect mysql to be the same since they run basically the same engine, right?

Thanks @Sybrand for the plugin :)

Sybrand commented 3 years ago

@esune the plugin should work with mysql, yes. One may have to use a different source image for the dockerfile - I used registry.access.redhat.com/rhscl/mariadb-102-rhel7 (depreceted b.t.w!) because it matches what we're using for our mariadb.

WadeBarnes commented 3 years ago

@Sybrand, Can you try using a newer base image. If it's anything like PostgreSQL as long as the backup container is running a version that is the same or newer than the database you're backing up or restoring things work just fine. For example the current version of the Postges backup container uses Postrgres 12, and it can backup and restore Postgres 9.5 databases.

esune commented 3 years ago

Can you try using a newer base image @WadeBarnes Is it worth using images from https://registry.fedoraproject.org so that we can be on more recent versions than the ones in the Red Hat Developer Portal?

esune commented 3 years ago

Alternatively: registry.access.redhat.com/rhscl/mariadb-102-rhel7. I am not sure whether these images can be pulled from outside OCP, so that was where my question about using the Fedora-based images was going, in addition to those being usually updated sooner.

WadeBarnes commented 3 years ago

I'm fine with Fedora images. As long as it works, it does not really make much difference.

Sybrand commented 3 years ago

@WadeBarnes the most recent version I see on redhat is mariadb-103-rhel7 ( https://catalog.redhat.com/software/containers/rhscl/mariadb-103-rhel7/5c9927a3bed8bd28d0e931d0) - but when I tried to use that, I couldn't - some credential error. @esune I'm not seeing any straight up MariaDB image on https://registry.fedoraproject.org . I have no issue upping the version - but I don't have a clue where to go for an appropriate image.

esune commented 3 years ago

@esune I'm not seeing any straight up MariaDB image on https://registry.fedoraproject.org . I have no issue upping the version - but I don't have a clue where to go for an appropriate image.

Their website is not great, this is the latest one that I can see: registry.fedoraproject.org/f31/mariadb - would have to look up what version that corresponds to.

The issue about being able to pull is what I was referring to above, unless you're on a machine with a rhscl license it will nt let you pull the image.

Sybrand commented 3 years ago

@esune I'm not seeing any straight up MariaDB image on https://registry.fedoraproject.org . I have no issue upping the version - but I don't have a clue where to go for an appropriate image.

Their website is not great, this is the latest one that I can see: registry.fedoraproject.org/f31/mariadb - would have to look up what version that corresponds to.

The issue about being able to pull is what I was referring to above, unless you're on a machine with a rhscl license it will nt let you pull the image.

Cool - got it https://registry.fedoraproject.org/repo/f31/mariadb/tags/ - looks to be 10.3

WadeBarnes commented 3 years ago

Thanks @Sybrand, I'll have a look tomorrow.