BCDevOps / bcdk

BC Developer Kit
Apache License 2.0
6 stars 15 forks source link

Jenkins Slaves Configuration & SonarQube generator #54

Closed usingtechnology closed 4 years ago

usingtechnology commented 4 years ago

Fix for the Jenkins slaves, the slave images were never being used - the jenkins image was being deployed as a slave. Changed the openshift templates and jenkins-overwrites to correctly deploy the slave image. Added node to the slave images so they can be used to build and run tests for sonarqube (assuming a node project).

Added a sonarqube "generator", included a sample jenkinsfile in the sonarqube README demonstrating how to use call sonarqube to run tests and publish results from a slave.

patricksimonian commented 4 years ago

can you reset your PR to not have the create label.yml commit? That commit belongs to a PR that is a work in progress :)

patricksimonian commented 4 years ago

@cvarjao what do you think of the jenkins image having node instead of using the npmw script?

patricksimonian commented 4 years ago

thanks for this contribution! We'll take a look at it and get back to you with any questions :) I'm wondering if this should be scheduled for a 0.1.0 release of the bcdk since it adds a major feature 🤔

usingtechnology commented 4 years ago

No worries. Just FYI, the SonarQube files were from BCDevOps/sonarqube in May. I see it has been bumped up, so could update the included yaml to use their latest?

cvarjao commented 4 years ago

@patricksimonian, I feel like each team could layer whatever utilities they need. I don't want to get in the business of managing Jenkins slave images for each technology again.

patricksimonian commented 4 years ago

closing this pr as its gone stale