BCDevOps / bcdk

BC Developer Kit
Apache License 2.0
6 stars 15 forks source link

Automatically clean PR deployments on PR close/merge #61

Closed BcGovNeal closed 4 years ago

BcGovNeal commented 4 years ago

Added functionality to automatically clean PR deployments using the existing clean.js script in the pipeline-cli.

Use the config.js to set transient: true on environments to be automatically cleaned.

patricksimonian commented 4 years ago

@cvarjao @BcGovNeal 🔥

BcGovNeal commented 4 years ago

The base Groovy script is taken out of the existing bcgov/jenkins-basic image. The only changes I made are the 3 lines in https://github.com/BCDevOps/bcdk/pull/61/commits/c5686a12e08a89efb7f61300a1a5d0f0b591dafe

patricksimonian commented 4 years ago

@BcGovNeal thanks for the contribution! So I think we can forgot testing for now. I don't really want to add anymore work to your contribution. We will get a test framework setup and add the tests ourselves later on. As far as some documention. It'd be helpful for our reference if there were a few comments explaining what is going on. Thanks again :) !!!