search

BCDevOps / nrdk

Natural Resource Ministries Developer/Deployment Kit
3 stars 4 forks source link

Close nrdk/issues/41 by using a getter for jira and bitbucket clients. #44

Closed cghobson closed 3 years ago

cghobson commented 3 years ago

Once more with feeling!

Creates an AxiosClient class that AxiosJiraClient and AxiosBitBucketClient inherit from. Moves the Axios constructor into the AxiosJiraClient / AxiosBitBucketClient since the factory shouldn't need to know/store the URL. Replaces const jira = this.jira as AxiosJiraClient with a this.jira() helper. Not touching init() for now. Removes promisify in secret-manager.ts with ReadFileSync, since awaiting a promise isn't better than just doing the work.

cghobson commented 3 years ago

Interesting, having the ability to insist that a variable exists is cool.