search

BCDevOps / openshift-tools

Apache License 2.0
15 stars 16 forks source link

Major update for OCP 3.10 monitoring #39

Closed wmhutchison closed 6 years ago

wmhutchison commented 6 years ago

Removed checks which broke due to being in a container versus a systemd service. May receive additional polishing over time.

StevenBarre commented 6 years ago

I see all the oc get outputs changed from plural to singular. I've found another way to get name lists from oc get that might be more future proof.

oc get -o=custom-columns=NAME:.metadata.name --no-headers <resource> should always produce just a list of the things, no need for sed.

Not sure if it's worth doing that in this PR or a separate one though.

wmhutchison commented 6 years ago

Applied all issues noted, as well as changes to remove the sed regarding parsing out "node" and "pod" (used to be "nodes" and "pods"). Future proofing is a good thing.