Closed mtsokol closed 2 years ago
Hi @j-ittner, I rebased it to the latest 2.0.x
and now inheritance is fixed.
PR is ready for another round of review!
Hi @j-ittner, I introduced all of the changes from your last review - it's ready for another one.
Hi @j-ittner @joerg-schneider!
Thank you for your guidance!
Here's a work-in-progress PR with clusterers support, for which I followed existing implementation. Please review if that's the right direction to go.
Here all clusterers are supported that implement
ClusterMixin
. For tomorrow I plan to add separate internalclustering
wrappers for twoKMeans
methods to also wrapcluster_centers_
in a dataframe.Also I've got a few questions about this design. One of them is that extending
LearnerDF
byClustererDF
imposes presence ofscore
method which is available in e.g.KMeans
but not inAgglomerativeClustering
. Other approach would be to removescore
fromLearnerDF
and introduceLearnerWithScoringDF
in the inheritance hierarchy but for the first POC I wanted to modify as little existing codebase as possible and wait for your review.Here's short interaction with this implementation:
labels_
preserves indexes and columns of DF used for fitting, alsopredict
does: