search

BCG-X-Official / sklearndf

DataFrame support for scikit-learn.
https://bcg-x-official.github.io/sklearndf/
Apache License 2.0
63 stars 7 forks source link

API: support for xgboost #215

Closed mtsokol closed 2 years ago

j-ittner commented 2 years ago

Hi @mtsokol before continuing this, can I suggest you review #214 then merge it into your branch? This may affect your code.

j-ittner commented 2 years ago

@mtsokol there was an obscure bug in pytools that caused a problem here. It is fixed in BCG-Gamma/pytools#333. Suggest you review then we release pytools 2.0.1. This PR should run successfully afterwards.

mtsokol commented 2 years ago

@mtsokol there was an obscure bug in pytools that caused a problem here. It is fixed in BCG-Gamma/pytools#333. Suggest you review then we release pytools 2.0.1. This PR should run successfully afterwards.

@j-ittner Thanks! The PR is ready and I also noticed a bug in pytools but didn't explore it. Reviewed!