BCG-X-Official / sklearndf

DataFrame support for scikit-learn.
https://bcg-x-official.github.io/sklearndf/
Apache License 2.0
63 stars 7 forks source link

API: simplify DF wrapper declarations #225

Closed j-ittner closed 2 years ago

j-ittner commented 2 years ago

Declare wrapper classes without stating the native estimator as a base class.

Stating the native estimator as a base class had originally been introduced to improve code completion in IDEs with static code inspection (e.g., PyCharm), but it turns out that in more recent versions this can lead to validation errors due to the mismatch between the untyped original methods (fit etc.) and the typed overrides in the DF wrapper classes.