search

BCHSI / philter-ucsf

Open source clinical text de-identification
BSD 3-Clause "New" or "Revised" License
107 stars 50 forks source link

replaced path+f constructions with os.path.join #10

Closed paulheider closed 11 months ago

paulheider commented 3 years ago

Several instances of path+f were used to create directory and filename compositions on-the-fly. These worked as long as all directory variable values ended in / (or the appropriate value for the given OS. Replacing these with os.path.join should make them more robust across OSes and to the inclusion or exclusion of the directory-ending /.

This command works for the current master:

python3 -m philter_ucsf -i data/i2b2_notes/ -o output/i2b2_demo/ -f ./configs/philter_delta.json --prod=True

This command only works after this merge request:

python3 -m philter_ucsf -i data/i2b2_notes -o output/i2b2_demo -f ./configs/philter_delta.json --prod=True

nathansutton commented 1 year ago

This is excellent and would have saved me a headache.